report: rename i18n to i18n-formatter, move strings to Util

[connorjclark]

All of renderer/i18n.js is formatting stuff, but it also doubled as a home for strings (including state, applying strings from the LHR). this pr:

• renames report/renderer/i18n.js to report/renderer/formatter.js
• moves the strings stuff to Util
• new function Util.applyStrings which takes care of adding the english fallbacks

[adamraine]

What was the reason we set these "static" variables here rather than in the class declaration? Might be a good comment to add.

[connorjclark]

In this case, it's because moving UIStrings declaration to be before the class will be bad for git blame history. I'm not sure that's a particularly useful thing to call out in a comment tho

[adamraine]

nit

Suggested change

	strings: Util.strings as typeof UIStrings & typeof Util.UIStrings,
	strings: Util.strings as (typeof UIStrings & typeof Util.UIStrings),

[brendankenny]

bumping strings up onto Util seems like a good move (and love dropping the type parameterization), but (bikeshed time) could i18n still be called i18n? formatter is kind of a mouthful and especially in the context of html generation makes me think of style formatting rather than localization.

[connorjclark]

bumping strings up onto Util seems like a good move (and love dropping the type parameterization), but (bikeshed time) could i18n still be called i18n? formatter is kind of a mouthful and especially in the context of html generation makes me think of style formatting rather than localization.

the main idea was to disambiguate these files:

I guess I'm fine with the property still being i18n, but are you also suggesting that formatter is a bad change for the file name too?

[brendankenny]

Descriptive but not optimal in this context, maybe? FWIW there's also shared/localization/format.js for further name confusion, which maybe should have been called formatter.js depending on where you fall on the nouns vs verbs thing, but that really only got a name at all because core/lib/i18n/i18n.js had to be split to move some of it to shared/.