misc(build): convert to ES modules #13967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
May 5, 2022
connorjclark
commented
May 5, 2022
build/tsconfig.json
Outdated
| "**/*.js", | ||
| "../types/global-lh.d.ts", | ||
| ], | ||
| } |
There was a problem hiding this comment.
@brendankenny any notes?
There was a problem hiding this comment.
What's it for? I'm surprised anything changed
There was a problem hiding this comment.
we import treemap ui strings and the locales module in build-treemap.js
and that requires various types to exist on the global scope otherwise tsc fails
There was a problem hiding this comment.
FWIW {"path": "./treemap/"}, in the root tsconfig.json would have also fixed it, though it's not necessarily bad to have a tsconfig for this folder too
Co-authored-by: Adam Raine <6752989+adamraine@users.noreply.github.com>
17 tasks
adamraine
approved these changes
May 6, 2022
brendankenny
reviewed
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #12689