Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: remove createCommonjsRefs #14004

Merged
merged 8 commits into from
Jun 9, 2022
Merged

misc: remove createCommonjsRefs #14004

merged 8 commits into from
Jun 9, 2022

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented May 14, 2022 •
edited
Loading

Fixes #13953

  • Removes createCommonjsRefs
  • Adds getModulePath and getModuleDirectory
  • Uses module directly for creating a require function

@connorjclark connorjclark requested a review from a team as a code owner May 14, 2022 00:07
@connorjclark connorjclark requested review from adamraine and removed request for a team May 14, 2022 00:07
adamraine
adamraine approved these changes May 16, 2022
View reviewed changes
esm-utils.mjs Outdated Show resolved Hide resolved
@devtools-bot devtools-bot merged commit 095d354 into master Jun 9, 2022
@devtools-bot devtools-bot deleted the rm-commonjsrefs branch June 9, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove createCommonjsRefs
3 participants
@connorjclark @adamraine @devtools-bot