Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(topbar): replace module mock with dependency injection #14057

Merged
merged 3 commits into from
May 31, 2022

Conversation

adamraine
Copy link
Member

@adamraine adamraine commented May 26, 2022

Instead of mocking a module, do dependency injection. This is necessary for #14054 because testdouble loader conflicts with the esm loader necessary for tsx files.

@adamraine adamraine requested a review from a team as a code owner May 26, 2022 16:59
@adamraine adamraine requested review from connorjclark and removed request for a team May 26, 2022 16:59
@adamraine adamraine changed the base branch from mocha-final to master May 26, 2022 18:22
@connorjclark connorjclark changed the title tests(topbar): remove testdouble tests(topbar): replace module mock with dependency injection May 26, 2022
@adamraine adamraine merged commit d81ecc9 into master May 31, 2022
@adamraine adamraine deleted the topbar-rm-mock branch May 31, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants