Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(largest-contentful-paint): remove m79 check #14082

Merged
merged 4 commits into from
Jun 13, 2022

Conversation

alexnj
Copy link
Member

@alexnj alexnj commented Jun 3, 2022

No description provided.

@alexnj alexnj requested a review from a team as a code owner June 3, 2022 22:09
@alexnj alexnj requested review from adamraine and connorjclark and removed request for a team June 3, 2022 22:09
@connorjclark connorjclark changed the title core(audit): remove LCP support checks for versions below m79 core(lcp): remove LCP support checks for versions below m79 Jun 3, 2022
@connorjclark connorjclark changed the title core(lcp): remove LCP support checks for versions below m79 core(largest-contentful-paint): remove m79 check Jun 3, 2022
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major throwback, this was my first contribution to LH #11016. So long brother 🫡

Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update from master, should fix CI.

@alexnj alexnj merged commit c873d92 into GoogleChrome:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants