deps(puppeteer): upgrade to 16.1.0 #14244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
Jul 28, 2022
connorjclark
changed the title
adamraine
changed the title
|
Bumping to 16: https://github.com/puppeteer/puppeteer/releases/tag/v16.0.0 This is the release with changes to how puppeteer handles iframes, so I am going to run our DT / FR tests a few times to see if any flakiness reeappers. |
connorjclark
reviewed
Aug 8, 2022
| @@ -216,7 +216,7 @@ describe('Lighthouse Viewer', () => { | |||
| document.querySelector('.lh-tools__dropdown')).visibility === 'visible'; | |||
| }); | |||
|
|
|||
| // For some reason, clicking this button doesn't always initiate the download after upgrading to Puppeteer 15.2.0. | |||
| // For some reason, clicking this button doesn't always initiate the download after upgrading to Puppeteer 16. | |||
There was a problem hiding this comment.
why update this line? presumably the version it broke in is useful information.
There was a problem hiding this comment.
I didn't do a bisect to find the revision that broke it, this is just calling out the version upgrade that introduced the problem for us.
connorjclark
approved these changes
Aug 8, 2022
alexnj
pushed a commit
to alexnj/lighthouse
that referenced
this pull request
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split of from #13901
At some point along the way, pptr added a
package.jsonfor the esm modules. This would be nice to have if we want to use the esm versions of the modules.This also fixes some outdated chrome issues with #14146