tests(smoke): check objects against a subset of keys #14270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
reviewed
Aug 9, 2022
| '9-2-BODY': {_fraggleRockOnly: true, ...elements.body}, | ||
| '9-1-HTML': {_fraggleRockOnly: true}, | ||
| _includes: [ | ||
| ['page-0-P', elements.p], |
There was a problem hiding this comment.
kinda crazy how well this composes
connorjclark
approved these changes
Aug 9, 2022
connorjclark
reviewed
Aug 9, 2022
connorjclark
reviewed
Aug 9, 2022
|
FWIW this doesn't really exist for jest's The ship has sailed on that decision if we want non-annoying backwards compatibility, but instead can we just pick non-flakey IDs instead of context IDs? We literally control these nodes' universe, there's no reason for us to have to use these Chrome-assigned numbers for their names. |
brendankenny
reviewed
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome execution context ids just changed under us again, so instead of adding another chrome version case we can change our smoke assertions to be more flexible.
This allows us to check the
Object.entriesof an object using_includesand_excludes.