tests(devtools): add i18n to e2e navigation test #14294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny and
adamraine
and removed request for
a team and
brendankenny
adamraine
reviewed
Aug 15, 2022
adamraine
approved these changes
Aug 16, 2022
alexnj
pushed a commit
to alexnj/lighthouse
that referenced
this pull request
Aug 24, 2022
copybara-service bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
Sep 7, 2022
Test expectations updated downstream: GoogleChrome/lighthouse#14294 Removes obsolete web tests. Bug: None Change-Id: I340f34a09fdf4d918c3a8398e3cf90f003a70528 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3876583 Reviewed-by: Andres Olivares <andoli@chromium.org> Reviewed-by: Connor Clark <cjamcl@chromium.org> Commit-Queue: Connor Clark <cjamcl@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple things need to change upstream, but we'll just handle that on the next roll.