core(smoke): support a per-runner test exclusion list

.github/workflows/devtools.yml

@@ -161,15 +161,7 @@ jobs:
     - run: mkdir latest-run
       working-directory: ${{ github.workspace }}/lighthouse
     - name: yarn smoke --runner devtools
-      # Disabled because normal Chrome usage makes DevTools not function on these poorly constructed pages
-      #   errors-expired-ssl, errors-infinite-loop, dbw (dialog prompt)
-      # Disabled because Chrome will follow the redirect first, and Lighthouse will only ever see/run the final URL.
-      #   redirects-client-paint-server, redirects-multiple-server, redirects-single-server, redirects-single-client
-      # Disabled because these tests use settings that cannot be fully configured in DevTools (e.g. throttling method "provided").
-      #   metrics-tricky-tti, metrics-tricky-tti-late-fcp, screenshot
-      # Disabled because of differences that need further investigation
-      #   byte-efficiency, byte-gzip, perf-preload
-      run: xvfb-run --auto-servernum yarn smoke --runner devtools --shard=${{ matrix.smoke-test-shard }}/${{ strategy.job-total }} --jobs=3 --retries=2 --invert-match byte-efficiency byte-gzip dbw errors-expired-ssl errors-infinite-loop metrics-tricky-tti metrics-tricky-tti-late-fcp perf-preload redirects-client-paint-server redirects-history-push-state redirects-multiple-server redirects-single-server redirects-single-client redirects-scripts screenshot
+      run: xvfb-run --auto-servernum yarn smoke --runner devtools --shard=${{ matrix.smoke-test-shard }}/${{ strategy.job-total }} --jobs=3 --retries=2
       working-directory: ${{ github.workspace }}/lighthouse
 
     - name: Upload failures

cli/test/smokehouse/config/exclusions.js

@@ -0,0 +1,31 @@
+/**
+ * @license Copyright 2022 The Lighthouse Authors. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+
+/**
+ * List of smoke tests excluded per runner. eg: 'cli': ['a11y', 'dbw']
+ * @type {Record<string, Array<string>>}
+ */
+const exclusions = {
+  'bundle': [],
+  'cli': [],
+  'devtools': [
+    // Disabled because normal Chrome usage makes DevTools not function on
+    // these poorly constructed pages
+    'errors-expired-ssl', 'errors-infinite-loop', 'dbw' /* dialog prompt */,
+    // Disabled because Chrome will follow the redirect first, and Lighthouse will
+    // only ever see/run the final URL.
+    'redirects-client-paint-server', 'redirects-multiple-server',
+    'redirects-single-server', 'redirects-single-client',
+    'redirects-history-push-state', 'redirects-scripts',
+    // Disabled because these tests use settings that cannot be fully configured in
+    // DevTools (e.g. throttling method "provided").
+    'metrics-tricky-tti', 'metrics-tricky-tti-late-fcp', 'screenshot',
+    // Disabled because of differences that need further investigation
+    'byte-efficiency', 'byte-gzip', 'perf-preload',
+  ],
+};
+
+export default exclusions;

cli/test/smokehouse/frontends/smokehouse-bin.js

@@ -24,6 +24,7 @@ import log from 'lighthouse-logger';
 import {runSmokehouse, getShardedDefinitions} from '../smokehouse.js';
 import {updateTestDefnFormat} from './back-compat-util.js';
 import {LH_ROOT} from '../../../../root.js';
+import exclusions from '../config/exclusions.js';
 
 const coreTestDefnsPath =
   path.join(LH_ROOT, 'cli/test/smokehouse/core-tests.js');
@@ -69,6 +70,7 @@ function getDefinitionsToRun(allTestDefns, requestedIds, {invertMatch}) {
   });
   if (unmatchedIds.length) {
     console.log(log.redify(`Smoketests not found for: ${unmatchedIds.join(' ')}`));
+    console.log(`Check test exclusions (${requestedIds.join(' ')})\n`);
     console.log(usage);
   }
 
@@ -193,8 +195,11 @@ async function begin() {
   const requestedTestIds = argv._;
   const {default: rawTestDefns} = await import(url.pathToFileURL(testDefnPath).href);
   const allTestDefns = updateTestDefnFormat(rawTestDefns);
+  const excludedTests = new Set(exclusions[argv.runner] || []);
+  const filteredTestDefns = allTestDefns.filter(test => !excludedTests.has(test.id));
   const invertMatch = argv.invertMatch;
-  const requestedTestDefns = getDefinitionsToRun(allTestDefns, requestedTestIds, {invertMatch});
+  const requestedTestDefns = getDefinitionsToRun(filteredTestDefns,
+    requestedTestIds, {invertMatch});
   const testDefns = getShardedDefinitions(requestedTestDefns, argv.shard);
 
   let smokehouseResult;