docs(config): update to reflect changes in FR #14321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Aug 25, 2022
| ViewportDimensions: 'ViewportDimensions', | ||
| WebAppManifest: 'WebAppManifest', | ||
| devtoolsLogs: 'devtoolsLogs', | ||
| traces: 'traces', | ||
| }; |
There was a problem hiding this comment.
Drive-by: since this config serves as our prime example, I thought this would help readability
| @@ -1,3 +1,5 @@ | |||
| > **WARNING**: This config format is for configs in version 10.0 and beyond. Please read the [legacy config](#legacy-configs) section if you are using the old config format. | |||
There was a problem hiding this comment.
Please mark this with a markdown/html comment: TODO 10.0 so we know to remove
There was a problem hiding this comment.
i guess you could also just follow up with a PR onto the docs staging branch
There was a problem hiding this comment.
You mean a TODO to remove this? The idea is that it will be removed in 11.0 / when legacy path is gone completely
connorjclark
approved these changes
Aug 25, 2022
adamraine
added a commit
that referenced
this pull request
Aug 26, 2022
This reverts commit ec4b36b.
adamraine
added a commit
that referenced
this pull request
Aug 26, 2022
| Doctype: '', | ||
| DOMStats: '', | ||
| EmbeddedContent: '', | ||
| FontSize: '', |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.