core: make bypass, th-has-data-cells, and video-caption informative
#14453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
You can confirm an axe check won't mix incomplete and failure by looking at the constitute checks source (here's a check source) and just seeing if any can return false And undefined (replace false with true if the check shows up in the rules "none"...)
I did the above for th-has-data-cells and it checks out. LGTM.
I did the above for bypass and found it should only return true or false, so wondered why it was giving incompletes (that should be only for undefined). Turns out rules have a "reviewOnFail" property. LGTM.
video-caption LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14354