report: sticky table headers #14508
Merged
report: sticky table headers #14508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
Nov 8, 2022
paulirish
reviewed
Nov 8, 2022
| } | ||
|
|
||
| .lh-table thead th { | ||
| position: sticky; |
There was a problem hiding this comment.
i would have expected to see these on the thead instead. i don't know if it makes a diff to the rendering engine but it feels nicer to manage the position of these as a group rather than individually.
wdyt?
There was a problem hiding this comment.
positioning that element does not work, it's a special display element
There was a problem hiding this comment.
Sorry, got bit confused here. thead support position: sticky but... border-bottom does not work b/c table borders are a special breed.
There was a problem hiding this comment.
True. I had thought I got it working, but couldn't reproduce it without losing the border.
All good!
paulirish
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chang required removing
overflow: hiddenfrom.lh-categories(unclear why this was there), otherwise the sticky positioning doesn't work. Also needed a bottom border on the th to separate it from the table body when positioned stickily, so now there's a bottom border on the th.