Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: reduce stuttery feel of gauge animation #14513

Merged
merged 1 commit into from
Nov 9, 2022
Merged

report: reduce stuttery feel of gauge animation #14513

merged 1 commit into from
Nov 9, 2022

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Nov 9, 2022 •
edited
Loading

Previous animation would go x, 0->x on load, with this PR it does 0->x and looks way less janky to me!

fixes #12412

@connorjclark connorjclark requested a review from a team as a code owner November 9, 2022 00:03
@connorjclark connorjclark requested review from adamraine and removed request for a team November 9, 2022 00:03
@brendankenny
Copy link
Member

fixes #12412 :)

@connorjclark connorjclark merged commit b4f24e3 into main Nov 9, 2022
@connorjclark connorjclark deleted the gauge-anim branch November 9, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

@paulirish paulirish paulirish approved these changes

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

score gauges first render complete, then do animation from 0 to complete
5 participants
@connorjclark @brendankenny @paulirish @adamraine @devtools-bot