Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix for page reload #14518

Closed

Conversation

wreszelewski
Copy link

Summary

This PR fixes a bug that appears when page is loaded multiple times during audit (ServiceWorker or js scripts).

Without this change some audits (e.g. Charset audit) are not performed correctly due to a problem with retriving of main document.

Related Issues/PRs

#10876

@wreszelewski wreszelewski requested a review from a team as a code owner November 10, 2022 12:40
@wreszelewski wreszelewski requested review from connorjclark and removed request for a team November 10, 2022 12:40
@google-cla
Copy link

google-cla bot commented Nov 10, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@wreszelewski wreszelewski changed the title core: Fix for page reload #10876 core: fix for page reload #10876 Nov 10, 2022
@wreszelewski wreszelewski changed the title core: fix for page reload #10876 core: fix for page reload Nov 10, 2022
@connorjclark
Copy link
Collaborator

Thanks! We need to apply this to the main branch, and I've added some tests, so I'll continue this here #14520. I'll be sure to add you as a co-contributor when it's ready to merge. Thanks for signing the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants