core: add usePassiveGathering flag
#14610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,6 +73,8 @@ export type ScreenEmulationSettings = { | |||
| debugNavigation?: boolean; | |||
| /** If set to true, will skip the initial navigation to about:blank. This option is ignored when using the legacy navigation runner. */ | |||
| skipAboutBlank?: boolean; | |||
| /** If set to true, gatherers should avoid any behavior that may be destructive to the page state. (e.g. extra navigations, resizing the viewport) */ | |||
| usePassiveGathering?: boolean; | |||
There was a problem hiding this comment.
should inclusion in this type imply it should be available via the cli?
There was a problem hiding this comment.
We never added skipAboutBlank because it isn't useful (cli starts on about:blank anyway).
For similar reasons usePassiveGathering isn't useful on the cli because it will always test a standalone navigation and then close the page. Preserving the page state isn't useful in this scenario.
That being said, it wouldn't be difficult to include just for consistency with other options on this type.
connorjclark
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can avoid weird audit skip logic in user flows #14465 (comment)
Will help with #14336