tests(devtools): support dbw smoke

[adamraine]

Would be nice to have DT smoke coverage of #14465. Turns out it was pretty easy to get dbw working in the DT smoke runner.

[adamraine]

#14465 (comment)

[brendankenny]

Nice! Did not remember dbw was in the exclusion list. We should look into those "need further investigation" ones at some point too.

[brendankenny]

the need for this means

lighthouse/core/gather/driver/prepare.js

Lines 51 to 70 in 1738b1a

	/**
	* Dismiss JavaScript dialogs (alert, confirm, prompt), providing a
	* generic promptText in case the dialog is a prompt.
	* @param {LH.Gatherer.FRProtocolSession} session
	* @return {Promise<void>}
	*/
	async function dismissJavaScriptDialogs(session) {
	session.on('Page.javascriptDialogOpening', data => {
	log.warn('Driver', `${data.type} dialog opened by the page automatically suppressed.`);
	session
	.sendCommand('Page.handleJavaScriptDialog', {
	accept: true,
	promptText: 'Lighthouse prompt response',
	})
	.catch(err => log.warn('Driver', err));
	});
	await session.sendCommand('Page.enable');
	}

isn't working in DevTools? :/

Lots of previous history

• handleJavascriptDialogs (#1939) #2106
• handle multiple javascript modal prompts #2120
• handle Page.handleJavaScriptDialog rejection #2402
• Lighthouse fails to dismiss page dialogs #2423
• Disable the dismissJavaScriptDialogs smoketest.  #2437
• core(driver): recover from rejection on handleJavaScriptDialog #6327
• tests(smoke): re-enable dialog prompt #8894

I guess we should open an issue?

[adamraine]

It is working in DevTools. In the setup for the test however, the dialog prevents pptr-run-devtools.js from starting the Lighthouse run. This PR just dismissed the dialog in the initial test setup so we can actually start the test. The dialog dismiss listener is then removed before the test starts.

During the test, the page is reloaded so the dialog appears again. This time the code you linked is responsible for dismissing the dialog.

[brendankenny]

Ah, I missed that this was running only before the test. Probably could use a comment but at least blame will find this :)