report: group third-party entities

[alexnj]

Part 3, "entity grouping and aggregation" changes of the design doc. This introduces grouping of audit results by entities, with aggregated values where applicable.

Summary of changes:

• All audits that deal with URLs are grouped by entity.
• Introduces a heading/group row to tables that feature: Entity's name, a category chip (or "1st Party") indicating the category of 3P, and a link to open the homepage of 3P (on hover).
• Report-side aggregate calculations. Columns with units bytes, numeric, ms, timespanMs are totaled by default. Can be avoided by dontAggregate: boolean flag on a column.
• Allow pre-grouped audit results (covers ThirdPartySummary audit).
• Introduce a sortBy directive in Table and Opportunity that indicates to report how aggregation logic should sort rows.

Pending fixes:

• Update base branch to main once report: use entity classification to filter third-parties #14697 lands.
• Fix issue with double-counting third-party group rows in report filter.
• Fix missing category names.
• i18n of strings.
• Update/add tests.
  • Grouping
  • Category name chips groups
  • 1st party chip in groups
  • Legacy non-grouped report and filtering (ensure it's working)
• Convert ThirdPartySummary.entity from a LinkValue to a string entity name.

Screenshot of Unused Javascript audit report below:

[connorjclark]

Can you address the "159 commits" thing? Maybe you need to squash+rebase with origin/main?

[alexnj]

Maybe you need to squash

Done.

[adamraine]

There are changes to the lhr like sortBy, skipSumming etc. I think it would be good to land those changes in 10.0 so that the 10.1 report renderer can handle 10.0 lhrs.

[connorjclark]

Those are additions, not breaking changes. 10.1 renderer (assuming with this PR) would just render 10.0 LHR as normal without aggregation, no? Doesn't seem critical to get those in for 10.0.

We could expedite 10.1 a bit (~3 weeks instead of 4-6) and still make the same Chromium cut, I believe. So to avoid CDT having a chrome release of 10.0 instead of 10.1. Is that your concern?

[adamraine]

Yeah I guess it's not breaking. SGTM

[alexnj]

I've updated this branch with latest UX recommendations so it should be good for review/merge.