Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(scoring): rebalance perf metric weightings for v10 #14667

Merged
merged 3 commits into from
Jan 18, 2023
Merged

core(scoring): rebalance perf metric weightings for v10 #14667

merged 3 commits into from
Jan 18, 2023

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Jan 11, 2023 •
edited by paulirish
Loading

ref #14565

#14586 updated with relevant things to update

Readable summary and FAQ coming.

Screen Shot 2023-01-12 at 1 11 49 PM

@connorjclark connorjclark requested a review from a team as a code owner January 11, 2023 21:49
@connorjclark connorjclark requested review from brendankenny and removed request for a team January 11, 2023 21:49
@paulirish paulirish changed the title core(scoring): drop TTI, add 10 points to CLS core(scoring): drop TTI, add 10 points to CLS, add 5 to TBT Jan 12, 2023
@paulirish paulirish changed the title core(scoring): drop TTI, add 10 points to CLS, add 5 to TBT core(scoring): rebalance perf metric weightings for v10 Jan 12, 2023
adamraine
adamraine approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The asymmetrical ordering is kinda meh but we already to it in timespan so 🤷

I lake having CWV metrics on one side and non-CWV metrics on the other too.

@connorjclark connorjclark merged commit 500022c into main Jan 18, 2023
@connorjclark connorjclark deleted the lh10-scoring branch January 18, 2023 22:09
@paulirish paulirish mentioned this pull request Jan 18, 2023
Merged
@adamraine adamraine mentioned this pull request Jan 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny brendankenny is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

@paulirish paulirish Awaiting requested review from paulirish

Assignees

@brendankenny brendankenny

Labels
10.0 waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @adamraine @brendankenny @devtools-bot