core(legacy): convert some base artifacts to regular gatherers #14680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Jan 13, 2023
| * @return {LH.RawIcu<Array<LH.Result.StackPack>>} | ||
| */ | ||
| function getStackPacks(pageStacks) { | ||
| if (!pageStacks) return []; |
There was a problem hiding this comment.
We can reach this condition on error reports now
There was a problem hiding this comment.
Isn't that just because of removing the initial values in initializeBaseArtifacts ? Maybe add them back?
There was a problem hiding this comment.
We shouldn't use initializeBaseArtifacts to subtly create a default value for some artifacts but not others IMO
connorjclark
approved these changes
Jan 17, 2023
adamraine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14678
I thought about putting bf-cache-failures in it's own pass, but that pass would probably require us to load the entire page without any shortcuts and/or require heavy modification to the legacy gather runner.
Instead, I chose to make the legacy runner more like the FR runner and just convert some base artifacts into regular artifacts.