core: merge Details.Opportunity with Details.Table #14771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexnj
force-pushed
the
tableOpportunity
branch
from
e242fc5 to
8fff7db
Compare
alexnj
force-pushed
the
tableOpportunity
branch
from
8fff7db to
156bfe2
Compare
alexnj
force-pushed
the
tableOpportunity
branch
from
156bfe2 to
00aef7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I took a stab at merging
Details.OpportunitywithDetails.Tableby introducing anisOpportunity?: booleanattribute to differentiate opportunities from tables.lighthouse-compatibility.OverallSavings{Ms|Bytes}are now calledwasted{Ms|Bytes}, as table summaries had it before. They mean about the same thing so I find the naming reasonable — wasted ms and bytes are opportunities. This would break less in compatibility (vs. making the table property sound more positive in nature, which would break compatibility for tables as well).