Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: use target type instead of session for oopif #15006

Merged
merged 19 commits into from
May 2, 2023
Merged

core: use target type instead of session for oopif #15006

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
49734d8
core: use target type instead of session for oopif
connorjclark Apr 21, 2023
bb84985
update sample json
connorjclark Apr 21, 2023
c6cb860
add back session id
connorjclark Apr 24, 2023
829fe99
send attached events to new listeners
connorjclark Apr 24, 2023
aa04f1b
clear payloads
connorjclark Apr 24, 2023
9406b1c
rename
connorjclark Apr 25, 2023
955dac0
add test for timespan network sources
connorjclark Apr 25, 2023
66a76c1
test name
connorjclark Apr 25, 2023
facc282
expand devtools log
connorjclark Apr 25, 2023
231672a
manually update logs
connorjclark Apr 25, 2023
2702a05
fix target manager test
connorjclark Apr 25, 2023
8d55cf4
support legacy
connorjclark Apr 25, 2023
7483edd
buttons
connorjclark Apr 26, 2023
96d9f3f
Update core/test/scenarios/api-test-pptr.js
connorjclark Apr 26, 2023
dbec910
change param type
connorjclark Apr 26, 2023
3feb432
Merge branch 'rm-sessionid' of github.com:GoogleChrome/lighthouse int…
connorjclark Apr 26, 2023
55234f1
map records to NR
connorjclark Apr 27, 2023
d9f87ad
rename
connorjclark Apr 27, 2023
48da6da
yay
connorjclark Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions cli/test/fixtures/oopif-simple-page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,29 +5,27 @@
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<script src="simple-script.js"></script>
</head>
<body>
<h1>Just a simple page</h1>
<script>
const shouldDeferStuff = location.search === '?defer';
const run = fn => {
if (shouldDeferStuff) {
setTimeout(fn, 2000);
} else {
fn();
}
};

run(() => {
if (shouldDeferStuff) {
const el = document.createElement('button');
el.textContent = 'Click to load scripts';
el.addEventListener('click', () => {
new Worker('simple-worker.mjs', { type: 'module' });
new Worker('simple-worker.js');
fetch('simple-script.js').then(r => r.text()).then(eval);
});
document.body.append(el);
} else {
new Worker('simple-worker.mjs', { type: 'module' });
new Worker('simple-worker.js');
});

window.addEventListener('load', () => {
run(() => {
window.addEventListener('load', () => {
fetch('simple-script.js').then(r => r.text()).then(eval);
});
});
}
</script>
</head>
<body>
<h1>Just a simple page</h1>
</body>
</html>
12 changes: 9 additions & 3 deletions core/test/scenarios/api-test-pptr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,19 @@ describe('Fraggle Rock API', function() {
});

// eslint-disable-next-line max-len
it('should know target type of network requests from frames created before timespan', async () => {
it.only('should know target type of network requests from frames created before timespan', async () => {
connorjclark marked this conversation as resolved.
Show resolved Hide resolved
state.server.baseDir = `${LH_ROOT}/cli/test/fixtures`;
const {page, serverBaseUrl} = state;

page.goto(`${serverBaseUrl}/oopif-scripts-timespan.html`);
await page.goto(`${serverBaseUrl}/oopif-scripts-timespan.html`);

const run = await api.startTimespan(state.page);
await page.waitForTimeout(8000);
for (const iframe of page.frames()) {
if (iframe.url().includes('/oopif-simple-page.html')) {
iframe.click('button');
}
}
await page.waitForNetworkIdle();
const result = await run.endTimespan();

if (!result) throw new Error('Lighthouse failed to produce a result');
Expand Down