core: move metric savings to audit product #15074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
May 12, 2023
proto/lighthouse-result.proto
Outdated
|
|
||
| // [EXPERIMENTAL] Estimates of how much this audit affects various performance | ||
| // metrics. Values will be in the unit of the respective metrics. | ||
| google.protobuf.Struct _metricSavings = 13; |
There was a problem hiding this comment.
Is renaming this to metricSavings going to cause issues down the line?
There was a problem hiding this comment.
can we just not include it in the proto yet?
There was a problem hiding this comment.
(otherwise it's my understanding that it'll have to ship in the proto forever, just not be populated anymore)
|
I didn't realize in #15071 (comment) that it wasn't on the actual audit result in the LHR, just on the intermediate audit product. Maybe the current way is the best way to land these, since we don't have to worry about them exposed in the LHR at all yet? |
|
Protobuf seems to be having issues with the leading We may need to remove the |
connorjclark
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original approach was flawed (see #15071)