core(server-response-time): fix for lightrider #15156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Jun 12, 2023
adamraine
reviewed
Jun 12, 2023
core/audits/server-response-time.js
Outdated
| const timing = record.timing; | ||
| return timing ? timing.receiveHeadersStart - timing.sendEnd : 0; | ||
| // Lightrider does not have timings for sendEnd, but we do have this timing which should be | ||
| // close. |
There was a problem hiding this comment.
Suggested change
| // close. | |
| // close to the response time. |
| @@ -61,6 +68,14 @@ class ServerResponseTime extends Audit { | |||
| const mainResource = await MainResource.request({devtoolsLog, URL: artifacts.URL}, context); | |||
|
|
|||
| const responseTime = ServerResponseTime.calculateResponseTime(mainResource); | |||
| if (responseTime === null) { | |||
There was a problem hiding this comment.
I'm not aware of a way to force a undefined timing with our unit testing, give we must construct a devtools log as the input.
| // close. | ||
| if (global.isLightrider && record.lrStatistics) return record.lrStatistics.requestMs; | ||
|
|
||
| if (!record.timing) return null; |
There was a problem hiding this comment.
If we are in LR will record.timing always be falsy?
There was a problem hiding this comment.
Not yet, that is to come.
adamraine
approved these changes
Jun 13, 2023
connorjclark
force-pushed
the
server-response-time-lr
branch
from
183454c to
a2e71c0
Compare
connorjclark
force-pushed
the
server-response-time-lr
branch
from
a2e71c0 to
9d2400e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the appropriate header in LR to estimate the server response time.