core(uses-rel-preconnect): add FCP and LCP savings #15281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
might need a double check to make sure there's good coverage on the tests |
adamraine
reviewed
Jul 18, 2023
adamraine
approved these changes
Jul 19, 2023
core/audits/uses-rel-preconnect.js
Outdated
| await LanternFirstContentfulPaint.getPessimisticGraph(pageGraph, processedNavigation); | ||
| const fcpGraphURLs = new Set(); | ||
| fcpGraph.traverse(node => { | ||
| if (node.type === 'network' ) fcpGraphURLs.add(node.record.url); |
There was a problem hiding this comment.
Nit: I realized this is copied but can you fix in both places?
Suggested change
| if (node.type === 'network' ) fcpGraphURLs.add(node.record.url); | |
| if (node.type === 'network') fcpGraphURLs.add(node.record.url); |
There was a problem hiding this comment.
uh why doesnt yarn lint catch this lol
There was a problem hiding this comment.
https://eslint.org/docs/latest/rules/no-multi-spaces
Looks like the lint rule only flags if there are multiple spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.