Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fix check for presence of all URL artifact fields #15648

Merged
merged 3 commits into from
Dec 1, 2023
Merged

core: fix check for presence of all URL artifact fields #15648

merged 3 commits into from
Dec 1, 2023

Conversation

connorjclark
Copy link
Collaborator

Code wasn't doing the job it thought it was.

@connorjclark connorjclark requested a review from a team as a code owner November 29, 2023 22:36
@connorjclark connorjclark requested review from adamraine and removed request for a team November 29, 2023 22:36
AuQaE referenced this pull request Nov 29, 2023
@connorjclark
test: use bash instead of sh to call test-recipes.sh (#15647)
ca95768
paulirish
paulirish approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow good catch

adamraine
adamraine approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ope 🙈

@connorjclark connorjclark merged commit 0c7a019 into main Dec 1, 2023
29 checks passed
@connorjclark connorjclark deleted the nav-runner-url-oops branch December 1, 2023 22:26
@ramzimalhas ramzimalhas mentioned this pull request Aug 22, 2024
Open
@Genio40921 Genio40921 mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

@paulirish paulirish paulirish approved these changes

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @paulirish @adamraine @devtools-bot