core(unused-css): exclude header size for estimating wasted bytes #15671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Dec 7, 2023
| "LCP": 0 | ||
| }, | ||
| "details": { | ||
| "type": "opportunity", | ||
| "headings": [], |
There was a problem hiding this comment.
TODO: I want to debug this change.
connorjclark
commented
Dec 7, 2023
| "scoreDisplayMode": "metricSavings", | ||
| "numericValue": 0, | ||
| "numericUnit": "millisecond", | ||
| "displayValue": "", | ||
| "displayValue": "Potential savings of 14 KiB", | ||
| "metricSavings": { |
There was a problem hiding this comment.
TODO: debug change.
There was a problem hiding this comment.
it disappeared when I rebased
connorjclark
commented
Dec 7, 2023
| @@ -288,8 +288,7 @@ function getResponseReceivedEvent(networkRecord, index, normalizedTiming) { | |||
| connectionId: networkRecord.connectionId || 140, | |||
| fromDiskCache: networkRecord.fromDiskCache || false, | |||
| fromServiceWorker: networkRecord.fetchedViaServiceWorker || false, | |||
| encodedDataLength: | |||
| networkRecord.responseHeadersTransferSize || networkRecord.transferSize || 0, | |||
| encodedDataLength: networkRecord.responseHeadersTransferSize || 0, | |||
There was a problem hiding this comment.
when responseHeadersTransferSize is not set the default should not be to make a record that treats all the bytes as being the size of the headers. thats what the old code was doing, and the test I modified revealed the error.
connorjclark
force-pushed
the
unused-css-transfer
branch
from
acafea5
to
67ba167
Compare
connorjclark
force-pushed
the
unused-css-transfer
branch
from
8e08da1
to
95a1a83
Compare
adamraine
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following up to #15640, but doing it for unused-css.