Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(bootup-time): exclude _lighthouse-eval.js #15678

Merged
merged 1 commit into from
Dec 8, 2023
Merged

core(bootup-time): exclude _lighthouse-eval.js #15678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/audits/bootup-time.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ class BootupTime extends Audit {
settings.throttling.cpuSlowdownMultiplier : 1;

const executionTimings = getExecutionTimingsByURL(tasks, networkRecords);
// Exclude our own tasks.
executionTimings.delete('_lighthouse-eval.js');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this inside getExecutionTImingsByURL?

Copy link
Collaborator Author

@connorjclark connorjclark Dec 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure. i think @brendankenny wanted this data intact for work-for-interaction. also, getExecutionTimingsByURL is in a lib folder, so we should try not to add overly lh-specific things there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, getExecutionTimingsByURL is in a lib folder, so we should try not to add overly lh-specific things there

Yes, this basically sums it up, but my opinion isn't strongly held. It's a balance between the expectation of _lighthouse-eval.js being filtered out and the expectation of all tasks in a period of a trace being accounted for. If there really was six seconds of a trace blocked by evaluate but it's filtered out, you might have trouble tracking down what's going on in the resulting audits, while if _lighthouse-eval.js isn't filtered out, it announces itself in the audit results.


const tbtImpact = await this.getTbtImpact(artifacts, context);

let hadExcessiveChromeExtension = false;
Expand Down
Loading