Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(css-usage): exclude empty stylesheets #15679

Merged
merged 1 commit into from
Dec 8, 2023
Merged

core(css-usage): exclude empty stylesheets #15679

merged 1 commit into from
Dec 8, 2023

Conversation

connorjclark
Copy link
Collaborator

noticed a NaN in unused-css computed artifact b/c of a 0 length stylesheet. we should just exclude those from gatherer.

@connorjclark connorjclark requested a review from a team as a code owner December 8, 2023 22:47
@connorjclark connorjclark requested review from adamraine and removed request for a team December 8, 2023 22:47
@connorjclark connorjclark merged commit 9ce7626 into main Dec 8, 2023
29 checks passed
@connorjclark connorjclark deleted the css-usage-empties branch December 8, 2023 23:29
@ramzimalhas ramzimalhas mentioned this pull request Aug 22, 2024
Open
@Genio40921 Genio40921 mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @adamraine @devtools-bot