core: score of 1 for informative audits #15689
Merged
+111
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Dec 12, 2023
| ? 100 | ||
| : Number(b.auditRef.result.score); | ||
| const scoreA = a.auditRef.result.score || 0; | ||
| const scoreB = b.auditRef.result.score || 0; |
There was a problem hiding this comment.
I kinda like this solution because it means the informative score accurately represents where informative audits should be in the sort order. Without this change we need a special exception for informative audits.
adamraine
changed the title
connorjclark
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15686
Nothing should change from the report perspective. This is for the benefit of JSON consumers that expect the score to change from 0 to 1 under passing conditions rather than 0 to null.