Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: remove pubads plugin #15843

Merged
merged 2 commits into from
Feb 28, 2024
Merged

core: remove pubads plugin #15843

merged 2 commits into from
Feb 28, 2024

Conversation

connorjclark
Copy link
Collaborator

ref #15841

We are moving Lantern around, and wish to avoid updating pubads in its current state, so are removing it now.

@connorjclark connorjclark requested a review from a team as a code owner February 28, 2024 23:23
@connorjclark connorjclark requested review from adamraine and removed request for a team February 28, 2024 23:23
@connorjclark connorjclark mentioned this pull request Feb 28, 2024
Open
6 tasks
adamraine
adamraine reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI will probably catch this but the DT e2e tests need updating as well

@connorjclark connorjclark merged commit 912495d into main Feb 28, 2024
28 of 29 checks passed
@connorjclark connorjclark deleted the rm-pubads branch February 28, 2024 23:56
@ramzimalhas ramzimalhas mentioned this pull request Aug 22, 2024
Open
@Genio40921 Genio40921 mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connorjclark @adamraine