-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(devtools): skip type checking in local builds #15858
Conversation
@@ -29,10 +30,10 @@ roll_devtools | |||
# `yarn devtools` deleted. | |||
gclient sync --delete_unversioned_trees --reset | |||
|
|||
if git config user.email | grep -q '@google.com'; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace this with the new remote option instead of removing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure DT frontend can be built on reclient (TBH I don't know if it was every working with goma either)
Following the Chromium instructions for reclient leads to build issues talking about a missing reclient config :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❯❯❯ gn args out/Default
Waiting for editor on "/Users/asraine/src/devtools/devtools-frontend/out/Default/args.gn"...
Generating files...
ERROR at //build/toolchain/rbe.gni:58:3: Script returned non-zero exit code.
exec_script(rebase_path("//build/toolchain/check_rewrapper_cfg.py"),
^----------
Current dir: /Users/asraine/src/devtools/devtools-frontend/out/Default/
Command: python3 /Users/asraine/src/devtools/devtools-frontend/build/toolchain/check_rewrapper_cfg.py ../../buildtools/reclient_cfgs/chromium-browser-clang/rewrapper_mac.cfg
Returned 1.
stderr:
reclient config file '/Users/asraine/src/devtools/devtools-frontend/buildtools/reclient_cfgs/chromium-browser-clang/rewrapper_mac.cfg' doesn't exist
To build with gn arg 'use_remoteexec=true' as a googler on a corp machine
set "download_remoteexec_cfg" in .gclient like
solutions = [
{
"name" : "src",
# ...
"custom_vars" : {
"download_remoteexec_cfg": True,
},
},
]
and re-run `gclient sync`.
See http://go/chrome-linux-build#setup-remote-execution
for more details.
See //third_party/typescript/typescript.gni:5:1: whence it was imported.
import("//build/toolchain/rbe.gni")
^---------------------------------
See //BUILD.gn:11:1: whence it was imported.
import("./third_party/typescript/typescript.gni")
^-----------------------------------------------
devtools_skip_typecheck=true
is the only way to really speed up DT builds according to this doc:https://chromium.googlesource.com/devtools/devtools-frontend/+/main/docs/get_the_code.md#standalone-checkout-build
Validating types is still valuable for each patch, so leaving it on in CI.
One annoying problem is that local builds will spit out a bunch of
[WARNING] Unrecognized target environment "es2022"
warnings for some reason :/This PR also removes the
use_goma=true
and requisite user email check because it has been removed from non-windows builds as of recently.