Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(devtools): use is_debug = true for local builds #15860

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

adamraine
Copy link
Member

According to simon (in chat):

Release build do some additional bundling with rollup and minification with terser and are the slowest.

Let's use debug builds for local debugging. In theory we could also do debug builds for CI, but I would prefer to play it safe and verify everything we do is compatible with release builds in CI.

Additionally, doesn't look like devtools_dcheck_always_on does anything anymore. I couldn't find any usages of this build arg and all the dcheck stuff from this CL is gone.

@adamraine adamraine requested a review from a team as a code owner March 8, 2024 19:01
@adamraine adamraine requested review from connorjclark and removed request for a team March 8, 2024 19:01
@adamraine adamraine merged commit ab9be18 into main Mar 8, 2024
29 checks passed
@adamraine adamraine deleted the dt-debug-build branch March 8, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants