tests(devtools): use is_debug = true
for local builds
#15860
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to simon (in chat):
Let's use debug builds for local debugging. In theory we could also do debug builds for CI, but I would prefer to play it safe and verify everything we do is compatible with release builds in CI.
Additionally, doesn't look like
devtools_dcheck_always_on
does anything anymore. I couldn't find any usages of this build arg and all the dcheck stuff from this CL is gone.