core: remove duplicate-id-active
#15900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
force-pushed
the
rm-dep-axe-checks
branch
from
9e3cab1 to
42574a8
Compare
adamraine
changed the title
duplicate-id-aria and duplicate-id-activeduplicate-id-active
connorjclark
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duplicate-id-activeis deprecated in axe-core (See dequelabs/axe-core#3892):Our internal review of accessibility audits does seem to contradict this a bit by saying it is a good signal. However, there were some concerns in that spreadsheet about how useful it was on page load, and since axe doesn't seem to be supporting it anymore I think it's safe to remove.
Part of #15440