core(driver): add sendCommandAndIgnore #15913
Conversation
paulirish
changed the title
| .catch(_ => {}); | ||
| void session.sendCommand('Runtime.terminateExecution').catch(_ => {}); | ||
| void session.sendCommandAndIgnore('Emulation.setScriptExecutionDisabled', {value: true}); | ||
| void session.sendCommandAndIgnore('Runtime.terminateExecution'); |
There was a problem hiding this comment.
Thoughts on making this return void, doing the void * hack inside the method?
if the semantics is just "toss this over to cdp and move on" we don't need to await anything.
There was a problem hiding this comment.
hmmm yeah. i'm up for tweaking it.
the void * thing (generally a convention from the devtools codebase) is for saying.. i'm not awaiting or returning this promise. https://typescript-eslint.io/rules/no-floating-promises/#ignorevoid
but the new AndIgnore method is for.. catching the rejection so it doesn't continue (or go unhandled)
they're slightly different things, right?
and it seems like we have cases where we want to await the AndIgnore calls .. and cases where we don't want to await them
So i think this new method should still return a promise. but.. it can be empty
and given this tweak, maybe ignore isn't a great fit. wdyt sendCommandQuietly? open to other names. (but also no big whoop on naming)
paulirish
force-pushed
the
sendCommandAndIgnore
branch
from
54c45d4 to
6cc86bd
Compare
connorjclark
changed the title
connorjclark
changed the title
followup from #15833 (review)