core(lantern): remove LR statistics #15946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Apr 15, 2024
| @@ -332,7 +334,7 @@ describe('DependencyGraph/Simulator/NetworkAnalyzer', () => { | |||
|
|
|||
| it('should use lrStatistics when needed', () => { | |||
| global.isLightrider = true; | |||
| const record = createRecord({timing: {}, lrStatistics: {requestMs: 100}}); | |||
| const record = createRecord({timing: {}, lrStatistics: {TCPMs: 1, requestMs: 100}}); | |||
There was a problem hiding this comment.
This was only accidentally working before - it was creating two NaN entries in the origin estimator using the code path I deleted. Without that code, zero samples were generated and the test was erroring w/ "No timing information".
adamraine
approved these changes
Apr 15, 2024
Co-authored-by: Adam Raine <6752989+adamraine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15944
Lantern does not need to know about our lrStatistics object. Instead, we can set the timing object based on it in our LH NetworkRequest -> Lantern NetworkRequest adapter.