Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: pass logger to smokehouse runners to get log even on timeout #16175

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

connorjclark
Copy link
Collaborator

When smokehouse runners timeout we don't get anything logged to help debug (unless the runner logged directly to stdout or stderr, which they try not to do).

Passing the logger to each runner so we can grab the log if we need to timeout should help with that.

@connorjclark connorjclark requested a review from a team as a code owner September 3, 2024 21:53
@connorjclark connorjclark requested review from adamraine and removed request for a team September 3, 2024 21:53
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes thanks!

@connorjclark connorjclark changed the title test: pass logger to smokehouse runners to get log even if timed out tests: pass logger to smokehouse runners to get log even if timed out Sep 3, 2024
@connorjclark connorjclark changed the title tests: pass logger to smokehouse runners to get log even if timed out tests: pass logger to smokehouse runners to get log even on timeout Sep 3, 2024
@connorjclark
Copy link
Collaborator Author

Needed to change to spawn so we can stream the output in the cli runner. Otherwise we still aren't getting anything when timing out.

@connorjclark connorjclark merged commit ba1a46c into main Sep 4, 2024
23 of 27 checks passed
@connorjclark connorjclark deleted the smokehouse-timed-out-logs branch September 4, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants