deps: upgrade trace_engine to 0.0.38
#16269
Conversation
| }, | ||
| { | ||
| url: 'http://localhost:10200/dobetterweb/fcp-delayer.js?delay=5000', | ||
| url: 'http://localhost:10200/dobetterweb/dbw_tester.css?delay=100', |
There was a problem hiding this comment.
Do you know why the order changes here? Looks like the order comes directly from TE so maybe some updated a while back applied a sort.
There was a problem hiding this comment.
it's sorted:
"// Sort by request duration for insights."
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5867686
|
The one devtools e2e failure: https://github.com/GoogleChrome/lighthouse/actions/runs/12127243835/job/33813041905#step:8:504 stops if this line is removed: unclear why this test has no issue from CDT repo side (EDIT: it's because the LH in CDT is still using the older trace engine :) ) it seems when "Clear Storage" is unset, we have no network info so the analyzer returns nothing and we get audit/insight errors. |
|
pushed a fallback for when we have no transfer data ... should match what was happening before. |
This captures a bunch of internal refactors, renames.
Another thing is the network analysis now more correctly gives no answer if there are no transfer sizes given to it (like for cached responses, or for fake data as in all our tests), so I updated our tests.
minor lantern test changes