ignore URL fragment when asserting page loaded #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebidel
reviewed
Feb 10, 2017
| @@ -135,7 +136,9 @@ class GatherRunner { | |||
| * @param {!Array<WebInspector.NetworkRequest>} networkRecords | |||
| */ | |||
| static assertPageLoaded(url, driver, networkRecords) { | |||
| const mainRecord = networkRecords.find(record => record.url === url); | |||
| const mainRecord = networkRecords.find(record => { | |||
There was a problem hiding this comment.
maybe add a comment here that the network record never sees the hash so we need to test the URL without it. Obvious?
ebidel
approved these changes
Feb 10, 2017
brendankenny
force-pushed
the
assertfrag
branch
from
3927f1d
to
5473acb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
came up in testing 1.5.0 for release. Runs fail testing e.g.
https://example.com/#/whateverTesting a URL with hash content will always fail the
GatherRunner.assertPageLoaded()check so this usesURL.equalWithExcludedFragmentsinstead of strict equality testing.