feat: backcompat config in report #2167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
changed the title
patrickhulce
force-pushed
the
config_in_lhr
branch
from
0569739 to
c16e73f
Compare
|
doesn't this get back to the larger question of if there's a difference between the json report and lhr? also, one issue is that config isn't always serializable. We'd need to drop live audits/gatherer classes if we want them to be |
|
yeah actually this isn't going to work :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2165
This changes both report generation functions in report generator to accept a lighthouse results object with a
.configproperty OR their original inputs (backcompat ftw)