polish: sizing tweaks for extremely narrow viewports #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
reviewed
May 18, 2017
| @@ -739,6 +745,7 @@ summary.lh-passed-audits-summary::-webkit-details-marker, | |||
| @media screen and (max-width: 767px) { | |||
| .lh-report { | |||
| margin-left: 0; | |||
| width: 100%; | |||
There was a problem hiding this comment.
i think we should set one min-width on lh-report or similar container...
to avoid this sorta thing
There was a problem hiding this comment.
sure, it seems to be a grab bag across devtools which panes shrink forever like this and which don't shrink at all and scroll as soon as it's less narrower than content, at what size do we want to stop shrinking?
There was a problem hiding this comment.
something reasonable.
i trust your judgement. :)
There was a problem hiding this comment.
added min-width 400px which is enough to cover the header gauges to prevent them from being their own separate scroll box, can probably lower it after #2297 :)
ebidel
approved these changes
May 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://bugs.chromium.org/p/chromium/issues/detail?id=723362