extension: Fix formatting of bug reports #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
suggested changes
May 23, 2017
| const body = '&body=' + encodeURI(qsBody); | ||
| const errorTitle = err.message.substring(0, MAX_ISSUE_ERROR_LENGTH); | ||
| const title = encodeURI('title=Extension Error: ' + errorTitle); | ||
| const body = '&body=' + encodeURI(issueBody.trim()); |
There was a problem hiding this comment.
this also needs encodeURIComponent
|
Redid it with URLSearchParams. Gets encoding for free. Bonus: If any of these characters ("&", "+", and "=") were in error message or stack, they would have broken the issue body (though the report would partially make it). This is fixed now. |
patrickhulce
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusing the refactor that's on the devtools side.
This fixes the incorrect triple-tick we currently have (with no newlines inbetween).
It also simplifies this bit.