Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide violations with no URL information #2352

Merged
merged 2 commits into from
Jun 1, 2017
Merged

fix: hide violations with no URL information #2352

merged 2 commits into from
Jun 1, 2017

Conversation

patrickhulce
Copy link
Collaborator

since switching to using violations, entries would appear in the table that had no actionable information, this filters those out

brendankenny
brendankenny approved these changes Jun 1, 2017
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@brendankenny brendankenny requested a review from ebidel June 1, 2017 23:13
@ebidel ebidel merged commit 73f9bc3 into master Jun 1, 2017
@ebidel ebidel deleted the filter_missing_urls branch June 1, 2017 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@ebidel ebidel ebidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickhulce @ebidel @brendankenny