Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable passing of a custom userDataDir to launcher #2357

Merged
merged 4 commits into from
Jun 5, 2017
Merged

Enable passing of a custom userDataDir to launcher #2357

merged 4 commits into from
Jun 5, 2017

Commits on Jun 5, 2017

  1. Enable passing of a custom userDataDir to launcher 

    * rename TMP_DIR to a more accurate name. Since this is a private
internal value, this is non-breaking.

Fixes #2291
    @samccone
    samccone committed Jun 5, 2017
    Configuration menu
    Copy the full SHA
    48124c3 View commit details
    Browse the repository at this point in the history

  2. Convert tests for launcher to typescript

    @samccone
    samccone committed Jun 5, 2017
    Configuration menu
    Copy the full SHA
    32fcb44 View commit details
    Browse the repository at this point in the history

  3. Implement tests for chrome launcher. 

    * Refactor code bits to make testable.
* Add the ability for a user to pass in module mocks to enable testing.
    @samccone
    samccone committed Jun 5, 2017
    Configuration menu
    Copy the full SHA
    0fe2fa8 View commit details
    Browse the repository at this point in the history

  4. Make launcher tests work w/ run-mocha command.

    @samccone
    samccone committed Jun 5, 2017
    Configuration menu
    Copy the full SHA
    a05e85d View commit details
    Browse the repository at this point in the history