Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable AppVeyor support. #2380

Merged
merged 2 commits into from
May 27, 2017
Merged

Re-enable AppVeyor support. #2380

merged 2 commits into from
May 27, 2017

Conversation

XhmikosR
Copy link
Contributor

  • Fix .appveyor.yml
  • Invalidate caching when yarn.lock changes

/CC @paulirish: I re-enabled the AppVeyor to build all branches in order to test this PR. So this should get merged ASAP if you want AppVeyor support again.

* Fix .appveyor.yml
* Invalidate caching when yarn.lock changes
@XhmikosR
Copy link
Contributor Author

Hmm, it seems AppVeyor is removed from this repository's integrations so it should be added back if you want to test things.

On a side note, @paulirish, you can always ping me for such issues and I can have a look as soon as I have some time instead of removing this completely :)

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good dude. appreciate the look.

I just flipped back on the webhook so after this merge we should be good. let's see..

@paulirish paulirish merged commit d0f4372 into GoogleChrome:master May 27, 2017
@paulirish
Copy link
Member

@XhmikosR i'm seeing this on the recent build:

image

@paulirish
Copy link
Member

paulirish commented May 27, 2017

@XhmikosR looks like this is fixed with the latest yarn. I've got a PR incoming to address.. #2382

@XhmikosR
Copy link
Contributor Author

@paulirish: cool, I added a few comments there.

@XhmikosR XhmikosR deleted the appveyor branch May 28, 2017 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants