-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run npm install/build tasks in parallel #2381
Conversation
you probably have to change the package.json to first install the concurrently package and than move forward. I also noticed that concurrently has some old npm packages. I'll create a PR to update their chalk dependency. |
package.json
Outdated
@@ -11,12 +11,12 @@ | |||
"node": ">=6" | |||
}, | |||
"scripts": { | |||
"install-all": "yarn && yarn install-launcher && yarn install-cli && yarn install-extension && yarn install-viewer", | |||
"install-all": "yarn && concurrently --kill-others-on-fail \"yarn install-launcher\" \"yarn install-cli\" \"yarn install-extension\" \"yarn install-viewer\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may or may not work on linux, apparently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can test real quick on linux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to clarify, it's the --kill-others-on-fail
that may not work on linux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at worst it'll just continue to run them all, even if one failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good if Travis is 👍
appveyor seems unhappy but not sure why |
Using this module now: https://github.com/madarche/npm-run-posix-or-windows/blob/master/bin/cli.js and basically letting windows get the slow path since it can't be trusted with being fancy. |
Looking at travis builds from today:
🚀 |
This makes install-all and build-all about 2-3x faster
On travis this takes:
install-all
from 28s to 12s.build-all
from 38s to 27s.