Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor fixes: fresh yarn, only node6 build #2382

Merged
merged 4 commits into from
May 30, 2017
Merged

Appveyor fixes: fresh yarn, only node6 build #2382

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e79398
hwo about this.
paulirish May 27, 2017
58384ba
move yarn install to right location.
paulirish May 27, 2017
0cc1528
only test node 6 on windows, as we only can do 1 concurrent job
paulirish May 28, 2017
bb7ccf7
add comment about node7 being excluded.
paulirish May 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@ clone_depth: 10
version: "{build}"

environment:
fast_finish: true
matrix:
- nodejs_version: "6.9.1"
platform: x86
- nodejs_version: "7"
- nodejs_version: "6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, you don't want to test node.js 7 anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally i do, but i'm not sure the delay is worth it.

appveyor is significantly slower of a VM than our travis bots, and they don't have a reasonable timeout on inactivity. which means they're very regularly our last CI to finish.

so this evens the playing field a bit, and i don't think missing out on node7/windows is all that bad.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, OK, that's reasonable. Maybe have a comment for the future in this file?

I'm not affiliated with AppVeyor but I guess you could report any issues to them :)
On a side note, did you compare cold phase? Because caching isn't enabled if the build fails.

platform: x86

build: off

install:
- ps: Install-Product node $env:nodejs_version $env:platform
- npm install yarn -g
- yarn
- yarn install-all

Expand All @@ -26,6 +26,7 @@ test_script:
- node --version
- npm --version
- yarn --version
- which yarn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows has where which is a native tool.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which does work in this case. shrug

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works because we have MSYS in PATH :P

- yarn lint
- yarn unit
- yarn smoke
Expand Down