Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update optimized-images overview jsdoc #2408

Merged
merged 1 commit into from
May 31, 2017
Merged

Update optimized-images overview jsdoc #2408

merged 1 commit into from
May 31, 2017

Conversation

ebidel
Copy link
Contributor

@ebidel ebidel commented May 31, 2017

@patrickhulce

No longer the case for jpeg.

brendankenny
brendankenny reviewed May 31, 2017
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth saying what equivalent quality we're trying to hit? Not sure how to measure it :) Is the only relative sort-of-universally-recognizable measure photoshop quality?

@brendankenny brendankenny changed the title Fix docs Update optimized-images overview jsdoc May 31, 2017
@patrickhulce
Copy link
Collaborator

heh, yeah we need a conversion table tracked over time since it's ~85 quality of what used to be the JPEG encoder before 2 weeks ago 😆

@patrickhulce patrickhulce merged commit 84d3664 into master May 31, 2017
@patrickhulce patrickhulce deleted the ebidel-patch-3 branch May 31, 2017 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny left review comments

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebidel @patrickhulce @brendankenny