-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readme: add notes on per runs #2410
Conversation
[skip ci]
ae85658
to
42151b1
Compare
Lighthouse ships with a [performance-only config](https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/config/perf.json) that you can use: | ||
|
||
```js | ||
const perfConfig: any = require('lighthouse/lighthouse-core/config/perf.json'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
launchChromeAndRunLighthouse
to be consistent with the other example
const perfConfig = require('lighthouse/lighthouse-core/config/perf.json');`
// ...
launchChromeAndRunLighthouse(url, flags, perfConfig).then(results => {...});
docs/readme.md
Outdated
@@ -28,6 +28,22 @@ launchChromeAndRunLighthouse('https://example.com', flags).then(results => { | |||
}); | |||
``` | |||
|
|||
## Performance-only Lighthouse run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use h3: ###
docs/readme.md
Outdated
lighthouse(url, flags, perfConfig) | ||
``` | ||
|
||
You can also craft your own config (e.g. [plots.json](https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/config/plots.json)) for completely custom runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sg. done. |
05a59af
to
65aa057
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.