Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove aggregations #2426

Merged
merged 1 commit into from
Jun 5, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions docs/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,18 +110,16 @@ As an example, here's a trace-only run that's reporting on user timings and crit
}
},

"aggregations": [{
"name": "Performance Metrics",
"description": "These encapsulate your app's performance.",
"scored": false,
"categorizable": false,
"items": [{
"audits": {
"user-timings": { "expectedValue": 0, "weight": 1 },
"critical-request-chains": { "expectedValue": 0, "weight": 1}
}
}]
}]
"categories": {
"performance": {
"name": "Performance Metrics",
"description": "These encapsulate your app's performance.",
"audits": [
{"id": "user-timings", "weight": 1},
{"id": "critical-request-chains", "weight": 1}
]
}
}
}
```

Expand Down
4 changes: 1 addition & 3 deletions lighthouse-cli/test/smokehouse/pwa-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,5 @@ module.exports = {
'themed-omnibox',
// https://github.com/GoogleChrome/lighthouse/issues/566
// 'cache-start-url'
],

aggregations: []
]
};
16 changes: 0 additions & 16 deletions lighthouse-cli/types/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,22 +29,8 @@ interface AuditFullResults {
[metric: string]: AuditFullResult
}

interface AggregationResultItem {
overall: number;
name: string;
scored: boolean;
subItems: Array<AuditFullResult|string>;
}

interface Aggregation {
name: string;
score: Array<AggregationResultItem>;
total: number;
}

interface Results {
url: string;
aggregations: Array<Aggregation>;
audits: AuditFullResults;
lighthouseVersion: string;
artifacts?: Object;
Expand All @@ -54,8 +40,6 @@ interface Results {

export {
Results,
Aggregation,
AggregationResultItem,
AuditResult,
AuditResults,
AuditFullResult,
Expand Down
222 changes: 0 additions & 222 deletions lighthouse-core/aggregator/aggregate.js

This file was deleted.

Loading