add units to LoadFastEnough debug string #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
requested changes
Jun 3, 2017
| @@ -116,7 +116,7 @@ class LoadFastEnough4Pwa extends Audit { | |||
| return { | |||
| rawValue: false, | |||
| // eslint-disable-next-line max-len | |||
| debugString: `First Interactive was at ${timeToFirstInteractive.toLocaleString()}. More details in the "Performance" section.`, | |||
| debugString: `First Interactive was at ${timeToFirstInteractive.toLocaleString()}ms. More details in the "Performance" section.`, | |||
There was a problem hiding this comment.
we separate numbers and unit with \xa0 these days.
but you might as well just use Util.formatMilliseconds which will round it to the tens place, fixing your other concern with these numbers. :)
paulirish
approved these changes
Jun 5, 2017
|
ready to land. just waiting for travis |
|
rebased to get the JavaScriptDialog change. Now I understand why you appeared on that commit @paulirish :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tiny change. From
First Interactive was found at 808.352, however, the network request latencies were not sufficiently realistic, so the performance measurements cannot be trusted.to
First Interactive was found at 808.352ms, however, the network request latencies were not sufficiently realistic, so the performance measurements cannot be trusted.